Software / code / prosody
Annotate
spec/util_time_spec.lua @ 11748:88ba05494d17 0.11
makefile: fix prosody.version target
POSIX is quite explicit regarding the precedence of AND-OR lists [0]:
> The operators "&&" and "||" shall have equal precedence and shall be
> evaluated with left associativity. For example, both of the following
> commands write solely `bar` to standard output:
> false && echo foo || echo bar
> true || echo foo && echo bar
Given that, `prosody.version` target behaves as
((((((test -f prosody.release && cp ...) ||
test -f ...) &&
sed ...) ||
test -f ...) &&
hexdump ...) ||
echo unknown > $@)
In the case of release tarballs, `prosody.release` does exist, so the
first AND pair is executed. Given that it's successful, then the first
`test -f` in the OR pair is ignored, and instead the `sed` in the AND
pair is executed. `sed` success, as `.hg_archival.txt` exists, making
the second `test -f` in the OR pair ignored, and `hexdump` in the AND
pair is executed. Now, given that `.hg` doesn't exist, it fails, so the
last `echo` is run, overwriting `prosody.version` with `unknown`.
This can be worked around placing `()` around the AND pairs. Decided to use
conditionals instead, as I think they better communicate the intention
of the block.
[0]: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_09_03
| author | Lucas <lucas@sexy.is> |
|---|---|
| date | Sun, 15 Aug 2021 04:10:36 +0000 |
| parent | 9193:aba99b6539f5 |
| rev | line source |
|---|---|
| 9193 | 1 describe("util.time", function () |
| 2 local time; | |
| 3 setup(function () | |
| 4 time = require "util.time"; | |
| 5 end); | |
| 6 describe("now()", function () | |
| 7 it("exists", function () | |
| 8 assert.is_function(time.now); | |
| 9 end); | |
| 10 it("returns a number", function () | |
| 11 assert.is_number(time.now()); | |
| 12 end); | |
| 13 end); | |
| 14 describe("monotonic()", function () | |
| 15 it("exists", function () | |
| 16 assert.is_function(time.monotonic); | |
| 17 end); | |
| 18 it("returns a number", function () | |
| 19 assert.is_number(time.monotonic()); | |
| 20 end); | |
| 21 it("time goes in one direction", function () | |
| 22 local a = time.monotonic(); | |
| 23 local b = time.monotonic(); | |
| 24 assert.truthy(a <= b); | |
| 25 end); | |
| 26 end); | |
| 27 end); | |
| 28 | |
| 29 | |
| 30 | |
| 31 |
