Software /
code /
prosody
Annotate
HACKERS @ 12227:88958c0ecab3
mod_http_file_share: Use alternate syntax for filename in Content-Disposition
The Lua string.format %q doesn't behave correctly for all characters
that should be escaped in a quoted-string. And who knows what effects
higher Unicode might have here.
Applying percent-encoding of filenames seems like the safest way to deal
with filenames, as well as being easier than implementing the actual
quoted-string transform, which seems complicated and I'm not even sure
it covers every possible character.
Filenames can safely be assumed to be UTF-8 since they are passed in an
attribute in the query without any escaping.
author | Kim Alvefur <zash@zash.se> |
---|---|
date | Sat, 29 Jan 2022 16:11:38 +0100 |
parent | 9858:54147de1d1b1 |
rev | line source |
---|---|
13 | 1 Welcome hackers! |
2 | |
1082 | 3 This project accepts and *encourages* contributions. If you would like to get |
4 involved you can join us on our mailing list and discussion rooms. More | |
7359
a5a080c12c96
Update every link to the documentation to use HTTPS
Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
parents:
2664
diff
changeset
|
5 information on these at https://prosody.im/discuss |
13 | 6 |
1082 | 7 Patches are welcome, though before sending we would appreciate if you read |
9858
54147de1d1b1
doc/coding_style.{txt,md}: Update coding style guide
Matthew Wild <mwild1@gmail.com>
parents:
7359
diff
changeset
|
8 docs/coding_style.md for guidelines on how to format your code, and other tips. |
2664 | 9 |
7359
a5a080c12c96
Update every link to the documentation to use HTTPS
Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
parents:
2664
diff
changeset
|
10 Documentation for developers can be found at https://prosody.im/doc/developers |
2664 | 11 |
12 Have fun :) |