Software /
code /
prosody
Annotate
spec/scansion/mam_prefs_prep.scs @ 11476:83e127eb91f9
util.datamapper: Deal with locally built stanzas missing xmlns
So the problem is that xmlns is not inherited when building a stanza,
and then :get_child(n, ns) with an explicit namespace does not find that
such child tags.
E.g.
local t = st.stanza("foo", { xmlns = "urn:example:bar" })
:text_tag("hello", "world");
assert(t:get_child("hello", "urn:example:bar"), "This fails");
Meanwhile, during parsing (util.xmppstream or util.xml) child tags do
get the parents xmlns when not overriding them.
Thus, in the above example, if the stanza is passed trough
`t = util.xml.parse(tostring(t))` then the assert succeeds.
This change makes it so that it leaves out the namespace argument to
:get_child when it is the same as the current/parent namespace, which
behaves the same for both built and parsed stanzas.
author | Kim Alvefur <zash@zash.se> |
---|---|
date | Tue, 23 Mar 2021 19:52:59 +0100 |
parent | 9729:4f6413ec08a8 |
child | 11727:f3aee8a825cc |
rev | line source |
---|---|
9729
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
1 # mod_mam shold apply JIDprep in prefs |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
2 |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
3 [Client] Romeo |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
4 jid: romeo@localhost |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
5 password: password |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
6 |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
7 ----- |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
8 |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
9 Romeo connects |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
10 |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
11 Romeo sends: |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
12 <iq id="lx2" type="set"> |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
13 <prefs xmlns="urn:xmpp:mam:2" default="roster"> |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
14 <always> |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
15 <jid>JULIET@MONTAGUE.LIT</jid> |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
16 </always> |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
17 <never> |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
18 <jid>MONTAGUE@MONTAGUE.LIT</jid> |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
19 </never> |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
20 </prefs> |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
21 </iq> |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
22 |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
23 Romeo receives: |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
24 <iq id="lx2" type="result"> |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
25 <prefs xmlns="urn:xmpp:mam:2" default="roster"> |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
26 <always> |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
27 <jid>juliet@montague.lit</jid> |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
28 </always> |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
29 <never> |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
30 <jid>montague@montague.lit</jid> |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
31 </never> |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
32 </prefs> |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
33 </iq> |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
34 |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
35 Romeo disconnects |
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
36 |