Annotate

TODO @ 11476:83e127eb91f9

util.datamapper: Deal with locally built stanzas missing xmlns So the problem is that xmlns is not inherited when building a stanza, and then :get_child(n, ns) with an explicit namespace does not find that such child tags. E.g. local t = st.stanza("foo", { xmlns = "urn:example:bar" }) :text_tag("hello", "world"); assert(t:get_child("hello", "urn:example:bar"), "This fails"); Meanwhile, during parsing (util.xmppstream or util.xml) child tags do get the parents xmlns when not overriding them. Thus, in the above example, if the stanza is passed trough `t = util.xml.parse(tostring(t))` then the assert succeeds. This change makes it so that it leaves out the namespace argument to :get_child when it is the same as the current/parent namespace, which behaves the same for both built and parsed stanzas.
author Kim Alvefur <zash@zash.se>
date Tue, 23 Mar 2021 19:52:59 +0100
parent 9803:35ef6af41600
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
5405
4f98f2f60e22 TODO: Remove 0.9
Matthew Wild <mwild1@gmail.com>
parents: 4938
diff changeset
1 == 1.0 ==
4138
62f5e6b11571 TODO: Update for 0.9 milestones
Matthew Wild <mwild1@gmail.com>
parents: 4134
diff changeset
2 - Roster providers
62f5e6b11571 TODO: Update for 0.9 milestones
Matthew Wild <mwild1@gmail.com>
parents: 4134
diff changeset
3 - Clustering
2663
b3d1c4985182 TODO: Update
Matthew Wild <mwild1@gmail.com>
parents: 1520
diff changeset
4 - World domination