Annotate

spec/util_envload_spec.lua @ 13762:81856814d74f 13.0

util.argparse: Fix bug (regression?) in argument parsing with --foo=bar After recent changes, '--foo bar' was working, but '--foo=bar' was not. The test had a typo (?) (bar != baz) and because util.argparse is not strict by default, the typo was not caught. The typo caused the code to take a different path, and bypassed the buggy handling of --foo=bar options. I've preserved the existing test (typo and all!) because it's still an interesting test, and ensures no unintended behaviour changes compared to the old code. However I've added a new variant of the test, with strict mode enabled and the typo fixed. This test failed due to the bug, and this commit introduces a fix.
author Matthew Wild <mwild1@gmail.com>
date Tue, 11 Mar 2025 18:27:36 +0000
parent 11489:37f49d0ad22c
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
11489
37f49d0ad22c util.envload: Add basic test of envload()
Kim Alvefur <zash@zash.se>
parents:
diff changeset
1 describe("util.envload", function()
37f49d0ad22c util.envload: Add basic test of envload()
Kim Alvefur <zash@zash.se>
parents:
diff changeset
2 local envload = require "util.envload";
37f49d0ad22c util.envload: Add basic test of envload()
Kim Alvefur <zash@zash.se>
parents:
diff changeset
3 describe("envload()", function()
37f49d0ad22c util.envload: Add basic test of envload()
Kim Alvefur <zash@zash.se>
parents:
diff changeset
4 it("works", function()
37f49d0ad22c util.envload: Add basic test of envload()
Kim Alvefur <zash@zash.se>
parents:
diff changeset
5 local f, err = envload.envload("return 'hello'", "@test", {});
37f49d0ad22c util.envload: Add basic test of envload()
Kim Alvefur <zash@zash.se>
parents:
diff changeset
6 assert.is_function(f, err);
37f49d0ad22c util.envload: Add basic test of envload()
Kim Alvefur <zash@zash.se>
parents:
diff changeset
7 local ok, ret = pcall(f);
37f49d0ad22c util.envload: Add basic test of envload()
Kim Alvefur <zash@zash.se>
parents:
diff changeset
8 assert.truthy(ok);
37f49d0ad22c util.envload: Add basic test of envload()
Kim Alvefur <zash@zash.se>
parents:
diff changeset
9 assert.equal("hello", ret);
37f49d0ad22c util.envload: Add basic test of envload()
Kim Alvefur <zash@zash.se>
parents:
diff changeset
10 end);
37f49d0ad22c util.envload: Add basic test of envload()
Kim Alvefur <zash@zash.se>
parents:
diff changeset
11 it("lets you pass values in and out", function ()
37f49d0ad22c util.envload: Add basic test of envload()
Kim Alvefur <zash@zash.se>
parents:
diff changeset
12 local f, err = envload.envload("return thisglobal", "@test", { thisglobal = "yes, this one" });
37f49d0ad22c util.envload: Add basic test of envload()
Kim Alvefur <zash@zash.se>
parents:
diff changeset
13 assert.is_function(f, err);
37f49d0ad22c util.envload: Add basic test of envload()
Kim Alvefur <zash@zash.se>
parents:
diff changeset
14 local ok, ret = pcall(f);
37f49d0ad22c util.envload: Add basic test of envload()
Kim Alvefur <zash@zash.se>
parents:
diff changeset
15 assert.truthy(ok);
37f49d0ad22c util.envload: Add basic test of envload()
Kim Alvefur <zash@zash.se>
parents:
diff changeset
16 assert.equal("yes, this one", ret);
37f49d0ad22c util.envload: Add basic test of envload()
Kim Alvefur <zash@zash.se>
parents:
diff changeset
17
37f49d0ad22c util.envload: Add basic test of envload()
Kim Alvefur <zash@zash.se>
parents:
diff changeset
18 end);
37f49d0ad22c util.envload: Add basic test of envload()
Kim Alvefur <zash@zash.se>
parents:
diff changeset
19
37f49d0ad22c util.envload: Add basic test of envload()
Kim Alvefur <zash@zash.se>
parents:
diff changeset
20 end)
37f49d0ad22c util.envload: Add basic test of envload()
Kim Alvefur <zash@zash.se>
parents:
diff changeset
21 -- TODO envloadfile()
37f49d0ad22c util.envload: Add basic test of envload()
Kim Alvefur <zash@zash.se>
parents:
diff changeset
22 end)