Annotate

plugins/muc/config_form_sections.lib.lua @ 13762:81856814d74f 13.0

util.argparse: Fix bug (regression?) in argument parsing with --foo=bar After recent changes, '--foo bar' was working, but '--foo=bar' was not. The test had a typo (?) (bar != baz) and because util.argparse is not strict by default, the typo was not caught. The typo caused the code to take a different path, and bypassed the buggy handling of --foo=bar options. I've preserved the existing test (typo and all!) because it's still an interesting test, and ensures no unintended behaviour changes compared to the old code. However I've added a new variant of the test, with strict mode enabled and the typo fixed. This test failed due to the bug, and this commit introduces a fix.
author Matthew Wild <mwild1@gmail.com>
date Tue, 11 Mar 2025 18:27:36 +0000
parent 9036:bb4dcc555091
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
9036
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
1 module:hook("muc-config-form", function(event)
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
2 table.insert(event.form, {
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
3 type = "fixed";
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
4 value = "Room information";
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
5 });
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
6 end, 100);
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
7
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
8 module:hook("muc-config-form", function(event)
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
9 table.insert(event.form, {
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
10 type = "fixed";
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
11 value = "Access to the room";
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
12 });
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
13 end, 90);
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
14
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
15 module:hook("muc-config-form", function(event)
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
16 table.insert(event.form, {
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
17 type = "fixed";
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
18 value = "Permissions in the room";
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
19 });
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
20 end, 80);
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
21
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
22 module:hook("muc-config-form", function(event)
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
23 table.insert(event.form, {
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
24 type = "fixed";
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
25 value = "Other options";
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
26 });
bb4dcc555091 MUC: Commit forgotten file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
27 end, 70);