Software / code / prosody
Annotate
spec/util_time_spec.lua @ 13765:7c57fb2ffbb0 13.0
mod_websocket: Merge session close handling changes from mod_c2s (bug fixes)
This should bring some fixes and general robustness that mod_websocket had
missed out on. The duplicated code here is not at all ideal. To prevent this
happening again, we should figure out how to have the common logic in a single
place, while still being able to do the websocket-specific parts that we need.
The main known bug that this fixes is that it's possible for a session to get
into a non-destroyable state. For example, if we try to session:close() a
hibernating session, then session.conn is nil and the function will simply
return without doing anything. In the mod_c2s code we already handle this, and
just destroy the session. But if a hibernating websocket session is never
resumed or becomes non-resumable, it will become immortal!
By merging the fix from mod_c2s, the session should now be correctly
destroyed.
| author | Matthew Wild <mwild1@gmail.com> |
|---|---|
| date | Tue, 11 Mar 2025 18:44:40 +0000 |
| parent | 9193:aba99b6539f5 |
| rev | line source |
|---|---|
| 9193 | 1 describe("util.time", function () |
| 2 local time; | |
| 3 setup(function () | |
| 4 time = require "util.time"; | |
| 5 end); | |
| 6 describe("now()", function () | |
| 7 it("exists", function () | |
| 8 assert.is_function(time.now); | |
| 9 end); | |
| 10 it("returns a number", function () | |
| 11 assert.is_number(time.now()); | |
| 12 end); | |
| 13 end); | |
| 14 describe("monotonic()", function () | |
| 15 it("exists", function () | |
| 16 assert.is_function(time.monotonic); | |
| 17 end); | |
| 18 it("returns a number", function () | |
| 19 assert.is_number(time.monotonic()); | |
| 20 end); | |
| 21 it("time goes in one direction", function () | |
| 22 local a = time.monotonic(); | |
| 23 local b = time.monotonic(); | |
| 24 assert.truthy(a <= b); | |
| 25 end); | |
| 26 end); | |
| 27 end); | |
| 28 | |
| 29 | |
| 30 | |
| 31 |
