Software / code / prosody
Annotate
spec/net_http_server_spec.lua @ 13765:7c57fb2ffbb0 13.0
mod_websocket: Merge session close handling changes from mod_c2s (bug fixes)
This should bring some fixes and general robustness that mod_websocket had
missed out on. The duplicated code here is not at all ideal. To prevent this
happening again, we should figure out how to have the common logic in a single
place, while still being able to do the websocket-specific parts that we need.
The main known bug that this fixes is that it's possible for a session to get
into a non-destroyable state. For example, if we try to session:close() a
hibernating session, then session.conn is nil and the function will simply
return without doing anything. In the mod_c2s code we already handle this, and
just destroy the session. But if a hibernating websocket session is never
resumed or becomes non-resumable, it will become immortal!
By merging the fix from mod_c2s, the session should now be correctly
destroyed.
| author | Matthew Wild <mwild1@gmail.com> |
|---|---|
| date | Tue, 11 Mar 2025 18:44:40 +0000 |
| parent | 8687:ee01578c67cb |
| rev | line source |
|---|---|
|
8413
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
1 describe("net.http.server", function () |
|
8687
ee01578c67cb
net.http.server: Prevent loading of net.server in tests (breaks unrelated tests for some reason)
Kim Alvefur <zash@zash.se>
parents:
8413
diff
changeset
|
2 package.loaded["net.server"] = {} |
|
8413
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
3 local server = require "net.http.server"; |
|
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
4 describe("events", function () |
|
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
5 it("should work with util.helpers", function () |
|
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
6 -- See #1044 |
|
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
7 server.add_handler("GET host/foo/*", function () end, 0); |
|
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
8 server.add_handler("GET host/foo/bar", function () end, 0); |
|
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
9 local helpers = require "util.helpers"; |
|
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
10 assert.is.string(helpers.show_events(server._events)); |
|
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
11 end); |
|
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
12 end); |
|
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
13 end); |