Annotate

TODO @ 13765:7c57fb2ffbb0 13.0

mod_websocket: Merge session close handling changes from mod_c2s (bug fixes) This should bring some fixes and general robustness that mod_websocket had missed out on. The duplicated code here is not at all ideal. To prevent this happening again, we should figure out how to have the common logic in a single place, while still being able to do the websocket-specific parts that we need. The main known bug that this fixes is that it's possible for a session to get into a non-destroyable state. For example, if we try to session:close() a hibernating session, then session.conn is nil and the function will simply return without doing anything. In the mod_c2s code we already handle this, and just destroy the session. But if a hibernating websocket session is never resumed or becomes non-resumable, it will become immortal! By merging the fix from mod_c2s, the session should now be correctly destroyed.
author Matthew Wild <mwild1@gmail.com>
date Tue, 11 Mar 2025 18:44:40 +0000
parent 9803:35ef6af41600
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
5405
4f98f2f60e22 TODO: Remove 0.9
Matthew Wild <mwild1@gmail.com>
parents: 4938
diff changeset
1 == 1.0 ==
4138
62f5e6b11571 TODO: Update for 0.9 milestones
Matthew Wild <mwild1@gmail.com>
parents: 4134
diff changeset
2 - Roster providers
62f5e6b11571 TODO: Update for 0.9 milestones
Matthew Wild <mwild1@gmail.com>
parents: 4134
diff changeset
3 - Clustering
2663
b3d1c4985182 TODO: Update
Matthew Wild <mwild1@gmail.com>
parents: 1520
diff changeset
4 - World domination