Annotate

HACKERS @ 13765:7c57fb2ffbb0 13.0

mod_websocket: Merge session close handling changes from mod_c2s (bug fixes) This should bring some fixes and general robustness that mod_websocket had missed out on. The duplicated code here is not at all ideal. To prevent this happening again, we should figure out how to have the common logic in a single place, while still being able to do the websocket-specific parts that we need. The main known bug that this fixes is that it's possible for a session to get into a non-destroyable state. For example, if we try to session:close() a hibernating session, then session.conn is nil and the function will simply return without doing anything. In the mod_c2s code we already handle this, and just destroy the session. But if a hibernating websocket session is never resumed or becomes non-resumable, it will become immortal! By merging the fix from mod_c2s, the session should now be correctly destroyed.
author Matthew Wild <mwild1@gmail.com>
date Tue, 11 Mar 2025 18:44:40 +0000
parent 9858:54147de1d1b1
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
13
716632cca05d Coding style doc, HACKERS file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
1 Welcome hackers!
716632cca05d Coding style doc, HACKERS file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
2
1082
f58394b9ba66 Word-wrap HACKERS file
Matthew Wild <mwild1@gmail.com>
parents: 527
diff changeset
3 This project accepts and *encourages* contributions. If you would like to get
f58394b9ba66 Word-wrap HACKERS file
Matthew Wild <mwild1@gmail.com>
parents: 527
diff changeset
4 involved you can join us on our mailing list and discussion rooms. More
7359
a5a080c12c96 Update every link to the documentation to use HTTPS
Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
parents: 2664
diff changeset
5 information on these at https://prosody.im/discuss
13
716632cca05d Coding style doc, HACKERS file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
6
1082
f58394b9ba66 Word-wrap HACKERS file
Matthew Wild <mwild1@gmail.com>
parents: 527
diff changeset
7 Patches are welcome, though before sending we would appreciate if you read
9858
54147de1d1b1 doc/coding_style.{txt,md}: Update coding style guide
Matthew Wild <mwild1@gmail.com>
parents: 7359
diff changeset
8 docs/coding_style.md for guidelines on how to format your code, and other tips.
2664
33651e3f68b2 HACKERS: Update
Matthew Wild <mwild1@gmail.com>
parents: 1082
diff changeset
9
7359
a5a080c12c96 Update every link to the documentation to use HTTPS
Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
parents: 2664
diff changeset
10 Documentation for developers can be found at https://prosody.im/doc/developers
2664
33651e3f68b2 HACKERS: Update
Matthew Wild <mwild1@gmail.com>
parents: 1082
diff changeset
11
33651e3f68b2 HACKERS: Update
Matthew Wild <mwild1@gmail.com>
parents: 1082
diff changeset
12 Have fun :)