Annotate

DEPENDS @ 13765:7c57fb2ffbb0 13.0

mod_websocket: Merge session close handling changes from mod_c2s (bug fixes) This should bring some fixes and general robustness that mod_websocket had missed out on. The duplicated code here is not at all ideal. To prevent this happening again, we should figure out how to have the common logic in a single place, while still being able to do the websocket-specific parts that we need. The main known bug that this fixes is that it's possible for a session to get into a non-destroyable state. For example, if we try to session:close() a hibernating session, then session.conn is nil and the function will simply return without doing anything. In the mod_c2s code we already handle this, and just destroy the session. But if a hibernating websocket session is never resumed or becomes non-resumable, it will become immortal! By merging the fix from mod_c2s, the session should now be correctly destroyed.
author Matthew Wild <mwild1@gmail.com>
date Tue, 11 Mar 2025 18:44:40 +0000
parent 8454:90962ef41bf3
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
5406
9903a03b7b3e DEPENDS: Update (LuaSec now has a rock) and add link to /doc/depends
Matthew Wild <mwild1@gmail.com>
parents: 4914
diff changeset
1
9903a03b7b3e DEPENDS: Update (LuaSec now has a rock) and add link to /doc/depends
Matthew Wild <mwild1@gmail.com>
parents: 4914
diff changeset
2 For full information on our dependencies, version requirements, and
8454
90962ef41bf3 DEPENDS: Change link to https
Kim Alvefur <zash@zash.se>
parents: 5406
diff changeset
3 where to find them, see https://prosody.im/doc/depends
5406
9903a03b7b3e DEPENDS: Update (LuaSec now has a rock) and add link to /doc/depends
Matthew Wild <mwild1@gmail.com>
parents: 4914
diff changeset
4
9903a03b7b3e DEPENDS: Update (LuaSec now has a rock) and add link to /doc/depends
Matthew Wild <mwild1@gmail.com>
parents: 4914
diff changeset
5 If you have luarocks available on your platform, install the following:
7
dcc5ac721c20 - Remove some debugging code
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
6
5406
9903a03b7b3e DEPENDS: Update (LuaSec now has a rock) and add link to /doc/depends
Matthew Wild <mwild1@gmail.com>
parents: 4914
diff changeset
7 - luaexpat
9903a03b7b3e DEPENDS: Update (LuaSec now has a rock) and add link to /doc/depends
Matthew Wild <mwild1@gmail.com>
parents: 4914
diff changeset
8 - luasocket
9903a03b7b3e DEPENDS: Update (LuaSec now has a rock) and add link to /doc/depends
Matthew Wild <mwild1@gmail.com>
parents: 4914
diff changeset
9 - luafilesystem
9903a03b7b3e DEPENDS: Update (LuaSec now has a rock) and add link to /doc/depends
Matthew Wild <mwild1@gmail.com>
parents: 4914
diff changeset
10 - luasec
7
dcc5ac721c20 - Remove some debugging code
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
11