Annotate

CONTRIBUTING @ 13765:7c57fb2ffbb0 13.0

mod_websocket: Merge session close handling changes from mod_c2s (bug fixes) This should bring some fixes and general robustness that mod_websocket had missed out on. The duplicated code here is not at all ideal. To prevent this happening again, we should figure out how to have the common logic in a single place, while still being able to do the websocket-specific parts that we need. The main known bug that this fixes is that it's possible for a session to get into a non-destroyable state. For example, if we try to session:close() a hibernating session, then session.conn is nil and the function will simply return without doing anything. In the mod_c2s code we already handle this, and just destroy the session. But if a hibernating websocket session is never resumed or becomes non-resumable, it will become immortal! By merging the fix from mod_c2s, the session should now be correctly destroyed.
author Matthew Wild <mwild1@gmail.com>
date Tue, 11 Mar 2025 18:44:40 +0000
parent 9946:ceaca48a7e6d
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
9946
ceaca48a7e6d CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff changeset
1 Thanks for your interest in contributing to the project!
ceaca48a7e6d CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff changeset
2
ceaca48a7e6d CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff changeset
3 There are many ways to contribute, such as helping improve the
ceaca48a7e6d CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff changeset
4 documentation, reporting bugs, spreading the word or testing the latest
ceaca48a7e6d CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff changeset
5 development version.
ceaca48a7e6d CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff changeset
6
ceaca48a7e6d CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff changeset
7 You can find more information on how to contribute at <https://prosody.im/doc/contributing>
ceaca48a7e6d CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff changeset
8
ceaca48a7e6d CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff changeset
9 See also the HACKERS and README files.