Annotate

HACKERS @ 11592:64cfa396bb84

net.server_epoll: Fix reporting of socket connect timeout If the underlying TCP connection times out before the write timeout kicks in, end up here with err="timeout", which the following code treats as a minor issue. Then, due to epoll apparently returning the EPOLLOUT (writable) event too, we go on and try to write to the socket (commonly stream headers). This fails because the socket is closed, which becomes the error returned up the stack to the rest of Prosody. This also trips the 'onconnect' signal, which has effects on various things, such as the net.connect state machine. Probably undesirable effects. With this, we instead return "connection timeout", like server_event, and destroy the connection handle properly. And then nothing else happens because the connection has been destroyed.
author Kim Alvefur <zash@zash.se>
date Mon, 07 Jun 2021 17:37:14 +0200
parent 9858:54147de1d1b1
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
13
716632cca05d Coding style doc, HACKERS file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
1 Welcome hackers!
716632cca05d Coding style doc, HACKERS file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
2
1082
f58394b9ba66 Word-wrap HACKERS file
Matthew Wild <mwild1@gmail.com>
parents: 527
diff changeset
3 This project accepts and *encourages* contributions. If you would like to get
f58394b9ba66 Word-wrap HACKERS file
Matthew Wild <mwild1@gmail.com>
parents: 527
diff changeset
4 involved you can join us on our mailing list and discussion rooms. More
7359
a5a080c12c96 Update every link to the documentation to use HTTPS
Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
parents: 2664
diff changeset
5 information on these at https://prosody.im/discuss
13
716632cca05d Coding style doc, HACKERS file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
6
1082
f58394b9ba66 Word-wrap HACKERS file
Matthew Wild <mwild1@gmail.com>
parents: 527
diff changeset
7 Patches are welcome, though before sending we would appreciate if you read
9858
54147de1d1b1 doc/coding_style.{txt,md}: Update coding style guide
Matthew Wild <mwild1@gmail.com>
parents: 7359
diff changeset
8 docs/coding_style.md for guidelines on how to format your code, and other tips.
2664
33651e3f68b2 HACKERS: Update
Matthew Wild <mwild1@gmail.com>
parents: 1082
diff changeset
9
7359
a5a080c12c96 Update every link to the documentation to use HTTPS
Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
parents: 2664
diff changeset
10 Documentation for developers can be found at https://prosody.im/doc/developers
2664
33651e3f68b2 HACKERS: Update
Matthew Wild <mwild1@gmail.com>
parents: 1082
diff changeset
11
33651e3f68b2 HACKERS: Update
Matthew Wild <mwild1@gmail.com>
parents: 1082
diff changeset
12 Have fun :)