Software / code / prosody
Annotate
CONTRIBUTING @ 11590:5aafb832c91b
core.portmanager: Fix race condition in initialization of SNI cert map
Under some circumstances when hosts and modules are loaded in some
certain order, entries end up missing from the SNI map. This manifests
in e.g. `curl https://localhost:5281/` giving an error about
"unrecognized name".
The `service` argument is `nil` when invoked from the "host-activated"
event, leading it to iterating over every service. And then it would not
be fetching e.g. `http_host` from the config, which explains why https
would sometimes not work due to the missing name entry.
Because when `service` is included, this limits the iteration to
matching entries, while also returning the same value as the `name` loop
variable. Because `name == service when service != nil` we can use name
instead in the body of the loop.
| author | Kim Alvefur <zash@zash.se> |
|---|---|
| date | Fri, 28 May 2021 17:09:22 +0200 |
| parent | 9946:ceaca48a7e6d |
| rev | line source |
|---|---|
|
9946
ceaca48a7e6d
CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
1 Thanks for your interest in contributing to the project! |
|
ceaca48a7e6d
CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
2 |
|
ceaca48a7e6d
CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
3 There are many ways to contribute, such as helping improve the |
|
ceaca48a7e6d
CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
4 documentation, reporting bugs, spreading the word or testing the latest |
|
ceaca48a7e6d
CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
5 development version. |
|
ceaca48a7e6d
CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
6 |
|
ceaca48a7e6d
CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
7 You can find more information on how to contribute at <https://prosody.im/doc/contributing> |
|
ceaca48a7e6d
CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
8 |
|
ceaca48a7e6d
CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
9 See also the HACKERS and README files. |