Software / code / prosody
Annotate
.semgrep.yml @ 12545:5059a639f61e
util.watchdog: Update to use "new" util.timer API
When this module was written, it wasn't possible to cancel or reschedule a
timer. Times have changed, and we should take advantage of those new methods.
This module becomes a very thin wrapper around util.timer now, but I'd argue
it's still a very common and useful concept/abstraction to have around.
Possible API change: this removes the 'last_reset' field of the watchdog. This
was never really intended as a public thing, and I can't find any code that
uses it, so I consider removal to be safe.
| author | Matthew Wild <mwild1@gmail.com> |
|---|---|
| date | Sat, 11 Jun 2022 21:11:01 +0100 |
| parent | 11289:c6965f3c321c |
| child | 12717:898e99f49d80 |
| rev | line source |
|---|---|
| 11289 | 1 rules: |
| 2 - id: log-variable-fmtstring | |
| 3 patterns: | |
| 4 - pattern: log("...", $A) | |
| 5 - pattern-not: log("...", "...") | |
| 6 message: Variable passed as format string to logging | |
| 7 languages: [lua] | |
| 8 severity: ERROR | |
| 9 - id: module-log-variable-fmtstring | |
| 10 patterns: | |
| 11 - pattern: module:log("...", $A) | |
| 12 - pattern-not: module:log("...", "...") | |
| 13 message: Variable passed as format string to logging | |
| 14 languages: [lua] | |
| 15 severity: ERROR | |
| 16 - id: module-getopt-string-default | |
| 17 patterns: | |
| 18 - pattern: module:get_option_string("...", $A) | |
| 19 - pattern-not: module:get_option_string("...", "...") | |
| 20 - pattern-not: module:get_option_string("...", host) | |
| 21 - pattern-not: module:get_option_string("...", module.host) | |
| 22 message: Non-string default from :get_option_string | |
| 23 severity: ERROR | |
| 24 languages: [lua] |
