Software / code / prosody
Annotate
spec/net_http_server_spec.lua @ 13792:4ea7bd7325be 13.0
core.portmanager: Restore use of per-host 'ssl' for SNI hosts. Fixes #1915.
This was an unintentional regression, as per-host 'ssl' options became valid
in 0.12 when SNI support was added for direct TLS ports. While we encourage
most people to use the simpler automatic certificate selection (and it seems
most do, given the overlooking of this bug), there are likely always going to
be use cases for manually-configured certificates.
The issue was introduced in commit 7e9ebdc75ce4 which inadvertently removed
the per-host option checking for SNI.
| author | Kim Alvefur <zash@zash.se> |
|---|---|
| date | Sat, 29 Mar 2025 22:25:19 +0100 |
| parent | 8687:ee01578c67cb |
| rev | line source |
|---|---|
|
8413
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
1 describe("net.http.server", function () |
|
8687
ee01578c67cb
net.http.server: Prevent loading of net.server in tests (breaks unrelated tests for some reason)
Kim Alvefur <zash@zash.se>
parents:
8413
diff
changeset
|
2 package.loaded["net.server"] = {} |
|
8413
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
3 local server = require "net.http.server"; |
|
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
4 describe("events", function () |
|
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
5 it("should work with util.helpers", function () |
|
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
6 -- See #1044 |
|
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
7 server.add_handler("GET host/foo/*", function () end, 0); |
|
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
8 server.add_handler("GET host/foo/bar", function () end, 0); |
|
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
9 local helpers = require "util.helpers"; |
|
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
10 assert.is.string(helpers.show_events(server._events)); |
|
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
11 end); |
|
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
12 end); |
|
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
13 end); |