Software / code / prosody
Annotate
spec/scansion/mam_prefs_prep.scs @ 10092:4b3c129e96f2 0.11
mod_websocket: Clone stanza before mutating (fixes #1398)
Checking for `stanza.attr.xmlns == nil` to determine if the stanza
object is an actual stanza (`<message>`, `<presence>` or `<iq>` in the
`jabber:client` or `jabbber:server` namespace) or some other stream
element.
Since this mutation is not reverted, it may leak to other places and
cause them to mistreat stanzas as stream elements. Especially in cases
like MUC where a single stanza is broadcast to many recipients.
| author | Kim Alvefur <zash@zash.se> |
|---|---|
| date | Sat, 20 Jul 2019 04:19:58 +0200 |
| parent | 9729:4f6413ec08a8 |
| child | 11727:f3aee8a825cc |
| rev | line source |
|---|---|
|
9729
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
1 # mod_mam shold apply JIDprep in prefs |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
2 |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
3 [Client] Romeo |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
4 jid: romeo@localhost |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
5 password: password |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
6 |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
7 ----- |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
8 |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
9 Romeo connects |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
10 |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
11 Romeo sends: |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
12 <iq id="lx2" type="set"> |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
13 <prefs xmlns="urn:xmpp:mam:2" default="roster"> |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
14 <always> |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
15 <jid>JULIET@MONTAGUE.LIT</jid> |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
16 </always> |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
17 <never> |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
18 <jid>MONTAGUE@MONTAGUE.LIT</jid> |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
19 </never> |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
20 </prefs> |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
21 </iq> |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
22 |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
23 Romeo receives: |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
24 <iq id="lx2" type="result"> |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
25 <prefs xmlns="urn:xmpp:mam:2" default="roster"> |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
26 <always> |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
27 <jid>juliet@montague.lit</jid> |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
28 </always> |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
29 <never> |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
30 <jid>montague@montague.lit</jid> |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
31 </never> |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
32 </prefs> |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
33 </iq> |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
34 |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
35 Romeo disconnects |
|
4f6413ec08a8
mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
36 |
