prosody
353836684009
.semgrep.yml

Find changesets by keywords by author, files, the commit message, revision number or hash, or revset expression.

Software / code / prosody

Annotate

.semgrep.yml @ 12468:353836684009

net.connect: Fix accumulation of connection attempt references Connection attempts that failed the Happy Eyeballs race were not unreferenced and would accumulate. Tested by inspecting the 'pending_connections_map' after establishing s2s with a s2s target where the IPv6 port has a -j DROP rule causing it to time out and the IPv4 attempt wins the race. Expected is that the losing connection stays around until net.server timeouts kick in where it should be removed. The map table should tend towards being empty during idle times.
author Kim Alvefur <zash@zash.se>
date Wed, 20 Apr 2022 22:41:54 +0200
parent 11289:c6965f3c321c
child 12717:898e99f49d80
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
11289
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
1 rules:
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
2 - id: log-variable-fmtstring
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
3 patterns:
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
4 - pattern: log("...", $A)
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
5 - pattern-not: log("...", "...")
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
6 message: Variable passed as format string to logging
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
7 languages: [lua]
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
8 severity: ERROR
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
9 - id: module-log-variable-fmtstring
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
10 patterns:
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
11 - pattern: module:log("...", $A)
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
12 - pattern-not: module:log("...", "...")
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
13 message: Variable passed as format string to logging
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
14 languages: [lua]
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
15 severity: ERROR
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
16 - id: module-getopt-string-default
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
17 patterns:
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
18 - pattern: module:get_option_string("...", $A)
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
19 - pattern-not: module:get_option_string("...", "...")
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
20 - pattern-not: module:get_option_string("...", host)
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
21 - pattern-not: module:get_option_string("...", module.host)
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
22 message: Non-string default from :get_option_string
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
23 severity: ERROR
c6965f3c321c lint: Add initial semgrep config
Kim Alvefur <zash@zash.se>
parents:
diff changeset
24 languages: [lua]