Software /
code /
prosody
Annotate
spec/scansion/issue505.scs @ 12790:24b55f0e2db9 0.12
mod_http: Allow disabling CORS in the http_cors_override option and by default
Fixes #1779.
Due to an oversight in the logic, if the user set 'enabled' to false in an
override, it would disable the item's requested CORS settings, but still apply
Prosody's default CORS policy.
This change ensures that 'enabled = false' will now disable CORS entirely for
the requested item.
Due to the new structure of the code, it was necessary to have a flag to say
whether CORS is to be applied at all. Rather than hard-coding 'true' here, I
chose to add a new option: 'http_default_cors_enabled'. This is a boolean that
allows the operator to disable Prosody's default CORS policy entirely (the one
that is used when a module or config does not override it). This makes it
easier to disable CORS and then selectively enable it only on services you
want it on.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Mon, 31 Oct 2022 14:32:02 +0000 |
parent | 9291:329a670ae975 |
rev | line source |
---|---|
9291
329a670ae975
spec/scansion: Ensure all scripts have sensible titles
Matthew Wild <mwild1@gmail.com>
parents:
9266
diff
changeset
|
1 # Issue 505: mod_muc doesn’t forward part statuses |
329a670ae975
spec/scansion: Ensure all scripts have sensible titles
Matthew Wild <mwild1@gmail.com>
parents:
9266
diff
changeset
|
2 |
9266
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
3 [Client] Romeo |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
4 jid: user@localhost |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
5 password: password |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
6 |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
7 [Client] Juliet |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
8 jid: user2@localhost |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
9 password: password |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
10 |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
11 ----- |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
12 |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
13 Romeo connects |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
14 |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
15 Romeo sends: |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
16 <presence to="room@conference.localhost/Romeo"> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
17 <x xmlns="http://jabber.org/protocol/muc"/> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
18 </presence> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
19 |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
20 Romeo receives: |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
21 <presence from='room@conference.localhost/Romeo'> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
22 <x xmlns='http://jabber.org/protocol/muc#user'> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
23 <status code='201'/> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
24 <item jid="${Romeo's full JID}" affiliation='owner' role='moderator'/> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
25 <status code='110'/> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
26 </x> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
27 </presence> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
28 |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
29 Romeo receives: |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
30 <message type='groupchat' from='room@conference.localhost'><subject/></message> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
31 |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
32 # Submit config form |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
33 Romeo sends: |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
34 <iq id='config1' to='room@conference.localhost' type='set'> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
35 <query xmlns='http://jabber.org/protocol/muc#owner'> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
36 <x xmlns='jabber:x:data' type='submit'> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
37 <field var='FORM_TYPE'> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
38 <value>http://jabber.org/protocol/muc#roomconfig</value> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
39 </field> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
40 </x> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
41 </query> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
42 </iq> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
43 |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
44 Romeo receives: |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
45 <iq id="config1" from="room@conference.localhost" type="result"> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
46 </iq> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
47 |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
48 # Juliet connects, and joins the room |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
49 Juliet connects |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
50 |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
51 Juliet sends: |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
52 <presence to="room@conference.localhost/Juliet"> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
53 <x xmlns="http://jabber.org/protocol/muc"/> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
54 </presence> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
55 |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
56 Juliet receives: |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
57 <presence from="room@conference.localhost/Romeo" /> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
58 |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
59 Juliet receives: |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
60 <presence from="room@conference.localhost/Juliet" /> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
61 |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
62 Juliet receives: |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
63 <message type='groupchat' from='room@conference.localhost'><subject/></message> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
64 |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
65 Romeo receives: |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
66 <presence from="room@conference.localhost/Juliet" /> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
67 |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
68 Juliet sends: |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
69 <presence type='unavailable' to='room@conference.localhost'> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
70 <status>Farewell</status> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
71 </presence> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
72 |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
73 Romeo receives: |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
74 <presence type='unavailable' from='room@conference.localhost/Juliet'> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
75 <status>Farewell</status> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
76 <x xmlns='http://jabber.org/protocol/muc#user'> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
77 <item jid="${Juliet's full JID}" affiliation='none' role='none'/> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
78 </x> |
c5267f5fd6e6
spec/scansion: Add scansion scripts used for testing
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
79 </presence> |