Software / code / prosody
Annotate
.semgrep.yml @ 13546:1a915c2e0fa4 0.12
mod_bookmarks: Suppress error publishing empty legacy bookmarks w/ no PEP node
It appears that when:
1) The user has no bookmarks 2 node in PEP
2) The client publishes an empty bookmark set to a legacy bookmarks location
3) mod_bookmarks will attempt to purge items from the non-existent node and
log an error about the failure (item-not-found).
This new code will suppress an item-not-found error from the purge operation
in the empty-bookmarks case, and adds a log message for any other error (this
is helpful because the existing log message confusingly says it was an error
*publishing* to the node, which isn't always accurate).
| author | Matthew Wild <mwild1@gmail.com> |
|---|---|
| date | Fri, 08 Nov 2024 10:24:42 +0000 |
| parent | 11289:c6965f3c321c |
| child | 12717:898e99f49d80 |
| rev | line source |
|---|---|
| 11289 | 1 rules: |
| 2 - id: log-variable-fmtstring | |
| 3 patterns: | |
| 4 - pattern: log("...", $A) | |
| 5 - pattern-not: log("...", "...") | |
| 6 message: Variable passed as format string to logging | |
| 7 languages: [lua] | |
| 8 severity: ERROR | |
| 9 - id: module-log-variable-fmtstring | |
| 10 patterns: | |
| 11 - pattern: module:log("...", $A) | |
| 12 - pattern-not: module:log("...", "...") | |
| 13 message: Variable passed as format string to logging | |
| 14 languages: [lua] | |
| 15 severity: ERROR | |
| 16 - id: module-getopt-string-default | |
| 17 patterns: | |
| 18 - pattern: module:get_option_string("...", $A) | |
| 19 - pattern-not: module:get_option_string("...", "...") | |
| 20 - pattern-not: module:get_option_string("...", host) | |
| 21 - pattern-not: module:get_option_string("...", module.host) | |
| 22 message: Non-string default from :get_option_string | |
| 23 severity: ERROR | |
| 24 languages: [lua] |
