Annotate

HACKERS @ 11665:148075532021

net.server_epoll: Prevent stack overflow of opportunistic writes net.http.files serving a big enough file on a fast enough connection with opportunistic_writes enabled could trigger a stack overflow through repeatedly serving more data that immediately gets sent, draining the buffer and triggering more data to be sent. This also blocked the server on a single task until completion or an error. This change prevents nested opportunistic writes, which should prevent the stack overflow, at the cost of reduced download speed, but this is unlikely to be noticeable outside of Gbit networks. Speed at the cost of blocking other processing is not worth it, especially with the risk of stack overflow.
author Kim Alvefur <zash@zash.se>
date Sun, 11 Jul 2021 09:39:21 +0200
parent 9858:54147de1d1b1
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
13
716632cca05d Coding style doc, HACKERS file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
1 Welcome hackers!
716632cca05d Coding style doc, HACKERS file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
2
1082
f58394b9ba66 Word-wrap HACKERS file
Matthew Wild <mwild1@gmail.com>
parents: 527
diff changeset
3 This project accepts and *encourages* contributions. If you would like to get
f58394b9ba66 Word-wrap HACKERS file
Matthew Wild <mwild1@gmail.com>
parents: 527
diff changeset
4 involved you can join us on our mailing list and discussion rooms. More
7359
a5a080c12c96 Update every link to the documentation to use HTTPS
Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
parents: 2664
diff changeset
5 information on these at https://prosody.im/discuss
13
716632cca05d Coding style doc, HACKERS file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
6
1082
f58394b9ba66 Word-wrap HACKERS file
Matthew Wild <mwild1@gmail.com>
parents: 527
diff changeset
7 Patches are welcome, though before sending we would appreciate if you read
9858
54147de1d1b1 doc/coding_style.{txt,md}: Update coding style guide
Matthew Wild <mwild1@gmail.com>
parents: 7359
diff changeset
8 docs/coding_style.md for guidelines on how to format your code, and other tips.
2664
33651e3f68b2 HACKERS: Update
Matthew Wild <mwild1@gmail.com>
parents: 1082
diff changeset
9
7359
a5a080c12c96 Update every link to the documentation to use HTTPS
Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
parents: 2664
diff changeset
10 Documentation for developers can be found at https://prosody.im/doc/developers
2664
33651e3f68b2 HACKERS: Update
Matthew Wild <mwild1@gmail.com>
parents: 1082
diff changeset
11
33651e3f68b2 HACKERS: Update
Matthew Wild <mwild1@gmail.com>
parents: 1082
diff changeset
12 Have fun :)