Software / code / prosody
Annotate
CONTRIBUTING @ 11665:148075532021
net.server_epoll: Prevent stack overflow of opportunistic writes
net.http.files serving a big enough file on a fast enough connection
with opportunistic_writes enabled could trigger a stack overflow through
repeatedly serving more data that immediately gets sent, draining the
buffer and triggering more data to be sent. This also blocked the server
on a single task until completion or an error.
This change prevents nested opportunistic writes, which should prevent
the stack overflow, at the cost of reduced download speed, but this is
unlikely to be noticeable outside of Gbit networks. Speed at the cost of
blocking other processing is not worth it, especially with the risk of
stack overflow.
| author | Kim Alvefur <zash@zash.se> |
|---|---|
| date | Sun, 11 Jul 2021 09:39:21 +0200 |
| parent | 9946:ceaca48a7e6d |
| rev | line source |
|---|---|
|
9946
ceaca48a7e6d
CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
1 Thanks for your interest in contributing to the project! |
|
ceaca48a7e6d
CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
2 |
|
ceaca48a7e6d
CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
3 There are many ways to contribute, such as helping improve the |
|
ceaca48a7e6d
CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
4 documentation, reporting bugs, spreading the word or testing the latest |
|
ceaca48a7e6d
CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
5 development version. |
|
ceaca48a7e6d
CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
6 |
|
ceaca48a7e6d
CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
7 You can find more information on how to contribute at <https://prosody.im/doc/contributing> |
|
ceaca48a7e6d
CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
8 |
|
ceaca48a7e6d
CONTRIBUTING: Add a short file referencing the online doc/contributing page
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
9 See also the HACKERS and README files. |