prosody
11765f0605ec
spec/scansion/mam_prefs_prep.scs

Find changesets by keywords by author, files, the commit message, revision number or hash, or revset expression.

Software / code / prosody

Annotate

spec/scansion/mam_prefs_prep.scs @ 12462:11765f0605ec

mod_s2s: Store real stanzas in session.sendq, rather than strings This is the "right" thing to do. Strings were more memory-efficient, but e.g. bypassed stanza filters at reconnection time. Also not being stanzas prevents us from potential future work, such as merging sendq with mod_smacks. Regarding performance: we should counter the probable negative effect of this change with other positive changes that are desired anyway - e.g. a limit on the size of the sendq, improved in-memory representation of stanzas, s2s backoff (e.g. if a remote server is persistently unreachable, cache this failure for a while and don't just keep forever queuing stanzas for it).
author Matthew Wild <mwild1@gmail.com>
date Wed, 23 Mar 2022 15:25:22 +0000
parent 11727:f3aee8a825cc
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
11727
f3aee8a825cc Fix various spelling errors (thanks codespell)
Kim Alvefur <zash@zash.se>
parents: 9729
diff changeset
1 # mod_mam should apply JIDprep in prefs
9729
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
2
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
3 [Client] Romeo
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
4 jid: romeo@localhost
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
5 password: password
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
6
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
7 -----
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
8
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
9 Romeo connects
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
10
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
11 Romeo sends:
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
12 <iq id="lx2" type="set">
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
13 <prefs xmlns="urn:xmpp:mam:2" default="roster">
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
14 <always>
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
15 <jid>JULIET@MONTAGUE.LIT</jid>
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
16 </always>
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
17 <never>
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
18 <jid>MONTAGUE@MONTAGUE.LIT</jid>
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
19 </never>
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
20 </prefs>
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
21 </iq>
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
22
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
23 Romeo receives:
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
24 <iq id="lx2" type="result">
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
25 <prefs xmlns="urn:xmpp:mam:2" default="roster">
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
26 <always>
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
27 <jid>juliet@montague.lit</jid>
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
28 </always>
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
29 <never>
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
30 <jid>montague@montague.lit</jid>
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
31 </never>
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
32 </prefs>
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
33 </iq>
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
34
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
35 Romeo disconnects
4f6413ec08a8 mod_mam: Add test for JID normalization in prefs (see #1275)
Kim Alvefur <zash@zash.se>
parents:
diff changeset
36