Software / code / prosody-modules
Changeset
5086:dec4b2e31d1c
mod_rest: Do not allow replies to <iq type=result> from webhooks
Replying to a result stanza could cause loops, just as replying to an
error.
No stanza.name check here but it should be fine since no other kinds of
stanzas have type=result, and the boolean logic would most definitely be
wrong on the first attempt.
| author | Kim Alvefur <zash@zash.se> |
|---|---|
| date | Sun, 27 Nov 2022 00:10:38 +0100 |
| parents | 5085:e384b91d0aa7 |
| children | 5087:438fbebf74ac |
| files | mod_rest/mod_rest.lua |
| diffstat | 1 files changed, 1 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/mod_rest/mod_rest.lua Tue Nov 22 16:59:52 2022 +0100 +++ b/mod_rest/mod_rest.lua Sun Nov 27 00:10:38 2022 +0100 @@ -500,7 +500,7 @@ local function handle_stanza(event) local stanza, origin = event.stanza, event.origin; - local reply_allowed = stanza.attr.type ~= "error"; + local reply_allowed = stanza.attr.type ~= "error" and stanza.attr.type ~= "result"; local reply_needed = reply_allowed and stanza.name == "iq"; local receipt;
