Changeset

5416:2393dbae51ed

mod_http_oauth2: Add option for specifying TTL of registered clients Meant to simplify configuration, since TTL vs ignoring expiration is expected to be the main thing one would want to configure. Unsure what the implications of having unlimited lifetime of clients are, given no way to revoke them currently, short of rotating the signing secret. On one hand, it would be annoying to have the client expire. On the other hand, it is trivial to re-register it.
author Kim Alvefur <zash@zash.se>
date Thu, 04 May 2023 18:41:33 +0200
parents 5415:f8797e3284ff
children 5417:3902082c42c4
files mod_http_oauth2/README.markdown mod_http_oauth2/mod_http_oauth2.lua
diffstat 2 files changed, 5 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/mod_http_oauth2/README.markdown	Wed May 03 10:55:22 2023 +0200
+++ b/mod_http_oauth2/README.markdown	Thu May 04 18:41:33 2023 +0200
@@ -98,12 +98,12 @@
 client registration.
 
 Dynamic client registration can be enabled by configuring a JWT key. Algorithm
-defaults to *HS256*.
+defaults to *HS256* lifetime defaults to forever.
 
 ```lua
 oauth2_registration_key = "securely generated JWT key here"
 oauth2_registration_algorithm = "HS256"
-oauth2_registration_options = { default_ttl = 60 * 60 * 24 * 90 }
+oauth2_registration_ttl = nil -- unlimited by default
 ```
 
 ### Supported flows
--- a/mod_http_oauth2/mod_http_oauth2.lua	Wed May 03 10:55:22 2023 +0200
+++ b/mod_http_oauth2/mod_http_oauth2.lua	Thu May 04 18:41:33 2023 +0200
@@ -77,7 +77,9 @@
 -- Used to derive client_secret from client_id, set to enable stateless dynamic registration.
 local registration_key = module:get_option_string("oauth2_registration_key");
 local registration_algo = module:get_option_string("oauth2_registration_algorithm", "HS256");
-local registration_options = module:get_option("oauth2_registration_options", { default_ttl = 60 * 60 * 24 * 90 });
+local registration_ttl = module:get_option("oauth2_registration_ttl", nil);
+local registration_options = module:get_option("oauth2_registration_options",
+	{ default_ttl = registration_ttl; accept_expired = not registration_ttl });
 
 local pkce_required = module:get_option_boolean("oauth2_require_code_challenge", false);