Software /
code /
prosody-modules
File
mod_statistics_auth/mod_statistics_auth.lua @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 29 Mar 2023 16:12:15 +0100 |
parent | 1440:78133eb11e7d |
line wrap: on
line source
-- mod_statistics_auth module:set_global(); local auth_ok, auth_fail = 0, 0 function module.add_host(module) module:hook("authentication-success", function(event) auth_ok = auth_ok + 1 end); module:hook("authentication-failure", function(event) auth_fail = auth_fail + 1 end); end module:provides("statistics", { statistics = { c2s_auth = { get = function () return auth_ok; end; tostring = tostring; }; c2s_authfail = { get = function () return auth_fail; end; tostring = tostring; }; } });