Software /
code /
prosody-modules
File
mod_offline_hints/mod_offline_hints.lua @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 29 Mar 2023 16:12:15 +0100 |
parent | 3500:e86315c9b5c4 |
line wrap: on
line source
-- mod_offline_hints -- -- Copyright (C) 2019 Marcos de Vera Piquero <marcos.devera@quobis.com> -- -- This file is MIT/X11 licensed. -- -- A module to discard hinted messages with no-store at mod_offline -- module:depends"offline"; local function handle_offline (event) local stanza = event.stanza; if (stanza:get_child("no-store", "urn:xmpp:hints") or stanza:get_child("no-permanent-store", "urn:xmpp:hints")) then module:log("debug", "Not storing offline stanza: %s (urn:xmpp:hints)", stanza); return false; end return nil; end module:hook("message/offline/handle", handle_offline); module:log("debug", "Module loaded");