Software /
code /
prosody-modules
File
mod_http_pep_avatar/mod_http_pep_avatar.lua @ 4651:8231774f5bfd
mod_cloud_notify_encrypted: Ensure body substring remains valid UTF-8
The `body:sub()` call risks splitting the string in the middle of a
multi-byte UTF-8 sequence. This should have been caught by util.stanza
validation, but that would have caused some havoc, at the very least causing
the notification to not be sent.
There have been no reports of this happening. Likely because this module
isn't widely deployed among users with languages that use many longer UTF-8
sequences.
The util.encodings.utf8.valid() function is O(n) where only the last
sequence really needs to be checked, but it's in C and expected to be fast.
author | Kim Alvefur <zash@zash.se> |
---|---|
date | Sun, 22 Aug 2021 13:22:59 +0200 |
parent | 4038:02d238799537 |
line wrap: on
line source
-- HTTP Access to PEP Avatar -- By Kim Alvefur <zash@zash.se> local mod_pep = module:depends"pep"; local um = require "core.usermanager"; local nodeprep = require "util.encodings".stringprep.nodeprep; local base64_decode = require "util.encodings".base64.decode; local urlencode = require "util.http".urlencode; module:depends("http") module:provides("http", { route = { ["GET /*"] = function (event, path) if path == "" then return [[<h1>Hello from mod_http_pep_avatar</h1><p>This module provides access to public avatars of local users.</p>]]; end; local request, response = event.request, event.response; local actor = request.ip; local user, item_id = path:match("^([^/]+)/(%x+)$"); if not user then user = path; end local prepped = nodeprep(user); if not prepped then return 400; end if prepped ~= user then response.headers.location = module:http_url() .. "/" .. urlencode(prepped); return 302; end if not um.user_exists(user, module.host) then return 404; end local pep_service = mod_pep.get_pep_service(user); local ok, avatar_hash, avatar_meta = pep_service:get_last_item("urn:xmpp:avatar:metadata", actor); if not ok or not avatar_hash then return 404; end if (item_id or avatar_hash) == request.headers.if_none_match then return 304; end local data_ok, avatar_data = pep_service:get_items("urn:xmpp:avatar:data", actor, item_id or avatar_hash); if not data_ok or type(avatar_data) ~= "table" or not avatar_data[item_id or avatar_hash] then return 404; end local info = avatar_meta.tags[1]:get_child("info"); if item_id and info.attr.id ~= item_id then info = nil; for altinfo in avatar_meta.tags[1]:childtags("info") do if altinfo.attr.id == item_id then info = altinfo; end end end if not info then return 404; end response.headers.etag = item_id or avatar_hash; response.headers.content_type = info and info.attr.type or "application/octet-stream"; local data = avatar_data[item_id or avatar_hash]; return base64_decode(data.tags[1]:get_text()); end; } });