Comparison

mod_rest: Ensure no attempt is made to reply to an error stanza Previously it was possible to return an error reply from a callback.

comparison

equal deleted inserted replaced

-:64aa1d9d70ac
+:8b489203e4d3
 	local code2err = require "net.http.errors".registry;
 	local function handle_stanza(event)
 		local stanza, origin = event.stanza, event.origin;
-		local reply_needed = stanza.name == "iq";
+		local reply_allowed = stanza.attr.type ~= "error";
+		local reply_needed = reply_allowed and stanza.name == "iq";
 		local receipt;
-		if stanza.attr.type == "error" then
+		if reply_allowed and stanza.name == "message" and stanza.attr.id and stanza:get_child("urn:xmpp:receipts", "request") then
-			reply_needed = false;
-		end
-		if stanza.name == "message" and stanza.attr.id and stanza:get_child("urn:xmpp:receipts", "request") then
 			reply_needed = true;
 			receipt = st.stanza("received", { xmlns = "urn:xmpp:receipts", id = stanza.id });
 		end
 		local request_body = encode(send_type, stanza);
 			}):next(function (response)
 				module:set_status("info", "Connected");
 				local reply;
 				local code, body = response.code, response.body;
-				if code == 202 or code == 204 then
+				if not reply_allowed then
+					return;
+				elseif code == 202 or code == 204 then
 					if not reply_needed then
 						-- Delivered, no reply
 						return;
 					end
 				else