Comparison

mod_smacks: Handle a client trying to <enable> twice, or trying to <enable> before resource binding (thanks Thijs Alkemade)

comparison

equal deleted inserted replaced

-:57ac609444c4
+:40b707d7a809
 	return session;
 end
 module:hook_stanza(xmlns_sm, "enable", function (session, stanza)
+	local err, err_text;
+	if session.smacks then
+		err, err_text = "unexpected-request", "Stream management already enabled for this stream";
+	elseif not session.resource then
+		err, err_text = "unexpected-request", "Attempted to enable stream management before resource binding";
+	end
+	if err then
+		session.log("warn", "Failed to enable smacks: %s", err_text); -- TODO: XEP doesn't say we can send error text, should it?
+		session.send(st.stanza("failed", { xmlns = xmlns_sm }):tag(err, { xmlns = xmlns_errors}));
+		return true;
+	end
 	module:log("debug", "Enabling stream management");
 	session.smacks = true;
 	wrap_session(session);